commit | 35c12ead7ded45e0b4a60731e57f9835aa2d80ef | [log] [tgz] |
---|---|---|
author | Donna Wu <donna.wu@intel.com> | Thu Sep 20 06:08:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 20 06:08:18 2018 |
tree | c5e7bc1d8309bda1da9d8caa5592974c0f116653 | |
parent | 5198461a66e4b38955fa03153762a501332d03be [diff] |
Reland: listen to UsbDeviceManagerClient in UsbChooserContext. The original CL has been reverted because it failed on USB browser tests for the race condition between UsbDeviceManager::SetClient() and UsbDeviceManagerClient::OnDeviceRemoved/Added() events. Before this CL, two client bindings from UsbDeviceManager to Blink have been made associated and a earlier connection is set up before all requests to UsbDeviceManager in this CL. The original CL's description: > For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled > after "OnDeviceRemoved". But for mojom interface UsbDeviceManager, > there is no way to provide such dependency among listeners. > > As all users will be converted from UsbService to UsbDeviceManager, > to avoid the potential race condition, WebUsbServiceImpl is made > listen to UsbChooserContext in this CL. > > Bug: 699790 > Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b > Reviewed-on: https://chromium-review.googlesource.com/1210386 Bug: 699790 Change-Id: Ied803bf1e3b0fcc8daad14f6acd4a6d3ca98129f Reviewed-on: https://chromium-review.googlesource.com/1226824 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592693}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .