commit | 378384acf5e76872e88c144e4ab8d154ce533f84 | [log] [tgz] |
---|---|---|
author | Ehsan Karamad <ekaramad@chromium.org> | Fri Aug 03 21:26:46 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 03 21:26:46 2018 |
tree | 99cbda54388271f7a99ae0adabe3da08401b5c27 | |
parent | d30c4f76ff56e988a509fa2dcdb37e54fd632bfa [diff] |
Make a BrowserPluginSpecific test a MimeHandlerViewTest All GuestViews except for MimeHandlerViewGuest are now implemented based on cross-process frames. There is however a hadnful of browser tests which are not MimeHandlerViewTest but still use BrowserPlugin. This CL will 1- Change the MimeHandlerViewTest from parameteric to normal test. Essentially, the UseCrossProcessFramesForGuest flag is unrelated to the MimeHandlerViewGuest. There is a separate flag for that matter which is "MimeHandlerViewInCrossProcessFrame" and will be added eventually when the a first version of MimeHandlerViewGuest based on cross-process frames is implemented on ToT. 2- Move WebViewBrowserPluginSpecificTest.AcceptTouchEvents to MimeHandlerViewTest. This involves overhauling the test test is also modified to load MimeHandlerViewGuest instead of WebViewGuest. The short-term plan is to change all such (BrowserPluginSpecific) tests to become MimeHandlerViewBrowserPluginSpecificTest. The longer term goal is to remove all such tests when MimeHandlerViewInCrossProcessFrames is shipped. Bug: 659750, 533069, 330264 Change-Id: Icad9ddd1f2d1e6851b20f6c0d923dd2192b7dcec Reviewed-on: https://chromium-review.googlesource.com/1161745 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#580655}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .