tree ef2819eff884f59760e3624fd05b1591fad585e0
parent a780469e2f2de600512c592c36041002dd697a33
author Scott Violet <sky@chromium.org> 1533791118 +0000
committer Commit Bot <commit-bot@chromium.org> 1533791118 +0000

Revert "views: changes test to not use equality"

This reverts commit 72a83a6c2276e5afcec4f87f2edad760a4809a20.

Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert.

Original change's description:
> views: changes test to not use equality
> 
> This test was assuming a newly created Window got a pointer value different
> than one recently destroyed. For whatever reason my recent patch made it more
> likely (on the msan bot) that the newly created pointer got the same value as
> the one destroyed, leading to failure.
> 
> I'm converting the test to verify the window is destroyed using a WindowTracker.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
> Reviewed-on: https://chromium-review.googlesource.com/1168466
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581788}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168762
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581791}