Google Git
Sign in
chromium / chromium / src.git / 39f11611199bde9f613f259cec00cb4b72240dd3
commit39f11611199bde9f613f259cec00cb4b72240dd3[log] [tgz]
authorHenrique Ferreiro <hferreiro@igalia.com>Mon Feb 11 15:22:04 2019
committerCommit Bot <commit-bot@chromium.org>Mon Feb 11 15:22:04 2019
tree7f5aa16ae5707308e5ee38dbd12aee103e82a98b
parent0867fe7b900c4989d5520b3612dd813e83e0ad33 [diff]
DCHECK the IdentityManager when local sync is not enabled

ProfileSyncService lacked a check on identity_manager_ not being nullptr
because that could be the case when local syncing was enabled. Make a proper
DCHECK by also verifying whether local sync is enabled.

Change-Id: I7d48ad2be17d06c4285473e245e7c44092c4fb68
Reviewed-on: https://chromium-review.googlesource.com/c/1424801
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630762}
2 files changed
tree: 7f5aa16ae5707308e5ee38dbd12aee103e82a98b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .