commit | 3d4d84928567f74d93d951932eafa1b3d779923b | [log] [tgz] |
---|---|---|
author | Vadym Doroshenko <dvadym@chromium.org> | Thu Jan 11 11:00:09 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 11 11:00:09 2018 |
tree | 5cad1fe54dd8af547d4d8c108e7e515b9962d56b | |
parent | 394e2975039888255c6b48f073e14531798e7ac1 [diff] |
Reland "Do not reveal username value till user gesture." Original change's description: > Passwords are not available for a page till user gesture. > But for usernames it was not implemented. This patch implements > this: use SetSuggestedValue for username and register > username_element to gatekeeper, which manages revealing > the input suggested value to JS after user action. > > Along the way, a small improvement was implemented, setting > the username value only in one place which simplifies the code. > Bug: 798492 > Change-Id: Ib37637dd861f44b94674c6d0060ebc91dfd73cff > Reviewed-on: https://chromium-review.googlesource.com/850394 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527598} Original Patch is PatchSet 1. Flakiness was fixed on CL https://chromium-review.googlesource.com/c/chromium/src/+/859960 This CL differs from original only in small compilation fix in PatchSet 5 (compilation errors were because of changes in another CL). TBR=battre@chromium.org Bug: 798492 Change-Id: Ife2f67ca2cd75372ef388d077acb9d53b47be92d Reviewed-on: https://chromium-review.googlesource.com/854173 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#528593}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .