)]}' { "commit": "3d92bf74af2cc8b18d8529b57b04d1d26aecf73e", "tree": "143fc9f76dbcc5c93b59d809827f8bb6432951d7", "parents": [ "f4a2c40eea222931f18ac9aa01b71496b0e0e04b" ], "author": { "name": "Matt Falkenhagen", "email": "falken@chromium.org", "time": "Mon May 20 07:25:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 20 07:25:14 2019" }, "message": "service worker: Simplify deletion states on ServiceWorkerRegistration.\n\nBefore this CL, ServiceWorkerRegistration had three states:\n- is_deleted\n- is_uninstalling\n- is_uninstalled\n\nIt\u0027s difficult to understand the differences. The tension that caused\nthe states seems to be that |is_deleted| was controlled by the lower-level\nstorage layer, and |is_uninstall{ing,ed}| by the higher-level API layer\nlike the implementation of unregister().\n\nThis CL aims to simplify things by removing the is_deleted flag. The\nlayers get a bit more blurry but the benefit is fewer states. There are\nlikely further cleanups and renamings possible to make this nicer.\n\nChange-Id: Iee1102da0a865f571bc8906e184dd16551541c1e\nBug: 964201\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616870\nReviewed-by: Makoto Shimazu \u003cshimazu@chromium.org\u003e\nCommit-Queue: Matt Falkenhagen \u003cfalken@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#661282}\n", "tree_diff": [ { "type": "modify", "old_id": "063223cb663a275237ec9c1be9faea108516c79d", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_context_core.h", "new_id": "b06af8e835c8389ce9bf97522adcf83a2975d690", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_context_core.h" }, { "type": "modify", "old_id": "72072a777b6418977d9a07389a5b55bf2a90d36e", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_register_job.cc", "new_id": "e5e181d8e1a585680a2ee168f2b2faeb14186474", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_register_job.cc" }, { "type": "modify", "old_id": "a724432e533a8f6500c09ddf254d8d94bcd1b9bb", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_registration.cc", "new_id": "09f039ec4890bac438b6dd459b437a797fd58732", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_registration.cc" }, { "type": "modify", "old_id": "12b6452471664ab5593df0b17f8d79e01de5af21", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_registration.h", "new_id": "69e36bd2bb9ba75237a87d91f91461e0a7ca8ff8", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_registration.h" }, { "type": "modify", "old_id": "0439d41c995bc1b69624f302852094c854d72bb5", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_storage.cc", "new_id": "bd5b44400aa32d702963c333b6a3f64d67f44b3a", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_storage.cc" }, { "type": "modify", "old_id": "cda01b59f27a3fa84336f465996b48781a316d4e", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_storage.h", "new_id": "02177be3e6080d771c6519947caf1a7d31f955d3", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_storage.h" }, { "type": "modify", "old_id": "3670546994416ad53aa2f5c9c88cbd4ff2fde775", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_storage_unittest.cc", "new_id": "3289028b233f35d3f05649319b7a8206d6620e34", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_storage_unittest.cc" }, { "type": "modify", "old_id": "9337618980f3cce2f4032bb27d7c7ee46afc482d", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_version.cc", "new_id": "d8d548a447bbce57515e01d42fe7b5e2c16b8567", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_version.cc" }, { "type": "modify", "old_id": "cc10f39e3cc72d3f0ee16072ee653270efbaa468", "old_mode": 33188, "old_path": "content/browser/service_worker/service_worker_version_unittest.cc", "new_id": "fa8ab958d8bb421e354b64e7d84ba9d128003e63", "new_mode": 33188, "new_path": "content/browser/service_worker/service_worker_version_unittest.cc" } ] }