tree 69be209e35811c97eab61c281cc6fb480181d9c5
parent 20cc6356bc2a6136f3b1c4602926aad443784270
author Trent Apted <tapted@chromium.org> 1527212414 +0000
committer Commit Bot <commit-bot@chromium.org> 1527212414 +0000

Revert "shared worker: Give the renderer a factory bundle when NetworkService is enabled."

This reverts commit 79573b376b7242d8eb416e5cae697bcd684f16ab.

Reason for revert: Suspect for msan failures starting

https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7284

errors like


=1==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x26931324 in is_empty ./../../base/unguessable_token.h:68:45
    #1 0x26931324 in blink::IdentifiersFactory::IdFromToken(base::UnguessableToken const&) ./../../third_party/blink/renderer/core/inspector/identifiers_factory.cc:95:0
    #2 0x26b81609 in blink::InspectorNetworkAgent::InspectorNetworkAgent(blink::InspectedFrames*, blink::WorkerGlobalScope*, v8_inspector::V8InspectorSession*) ./../../third_party/blink/renderer/core/inspector/inspector_network_agent.cc:1809:23
...
 Uninitialized value was created by a heap allocation
    #0 0xac2699 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:45:35
    #1 0x2e6764af in blink::WebSharedWorker::Create(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:392:27
    #2 0x2ac0c8ea in content::EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub

Original change's description:
> shared worker: Give the renderer a factory bundle when NetworkService is enabled.
> 
> Similar to frames, the shared worker needs a factory bundle in order to
> load non-NetworkService URLs like chrome-extension://.
> 
> This fixes the remaining test failure but we're still missing test
> coverage. I think the factory bundle needs to be propagated to
> ServiceWorkerSubresourceLoaderFactory for use with network fallback.
> 
> Bug: 839982
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d
> Reviewed-on: https://chromium-review.googlesource.com/1069956
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561423}

TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org

Change-Id: Iada07ec8bdddf612dbd441f702ede3dc8239ad21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1073007
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561728}