commit | 4c1b499d39b560836924662a6cbe49b3679d4c97 | [log] [tgz] |
---|---|---|
author | manuk <manukh@chromium.org> | Fri Oct 26 22:35:24 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 26 22:35:24 2018 |
tree | 7de17eab9d8ab4a950a450eff317d31ec18b45f5 | |
parent | cd3d77a629503fbe327e15940792b3647931393f [diff] |
[chrome:omnibox]: Refactoring HTML generation part 1/3, create OutputMatch helper class. This is the first of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we: - Replaced the functions createCellForPropertyAndRemoveProperty and addResultTableToOutput with OutputMatch, which is responsible for generating individual HTML rows from individual omnibox matches. - Moved the data class PresentationInfoRecord and the constants array of PresentationInfoRecord's PROPERTY_OUTPUT_ORDER from omnibox.js to omnibox_output.js as that's where it's now used. Bug: 891303 Change-Id: If653e16763a3956b0576bf677ede1570626007d7 Reviewed-on: https://chromium-review.googlesource.com/c/1293757 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603225}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .