Google Git
Sign in
chromium / chromium / src.git / 4d572e9d38fa4366aefa2f357eb699df7b600fc6
commit4d572e9d38fa4366aefa2f357eb699df7b600fc6[log] [tgz]
authorYao Xiao <yaoxia@chromium.org>Thu Jan 24 08:09:40 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 24 08:09:40 2019
treef7d17e7a25e3f8fcbf8995b8f0ec5eba483e1530
parent3813e5d355f3720d350a2de6e80e2fd3aefb68cc [diff]
Fixed the download intervention in sandbox for RemoteFrame::Navigate path.

Also, fixed test assertions that verify download is not happening: previously we
check the UMA too soon before download decision is made, which may give us false
negatives. The fix is to explicitly wait for
OnDidFinishSubFrameNavigation(), and check the UMA after the waiting.

Bug: 539938
Change-Id: Ib1a829420d68969877454413d0e2c7390a323b21
Reviewed-on: https://chromium-review.googlesource.com/c/1406153
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625557}
12 files changed
tree: f7d17e7a25e3f8fcbf8995b8f0ec5eba483e1530
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .