commit | 6740d6248c24fdb1a591dad3aaaf312919e35fa5 | [log] [tgz] |
---|---|---|
author | Xi Han <hanxi@google.com> | Tue May 22 19:21:07 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 22 19:21:07 2018 |
tree | fbdcd83932e947efaabde4ba349f043c53121e16 | |
parent | 703dacb4c96a21f6195d0d2091dc695853d99a5f [diff] |
Reland "Create BrowserThread::IO thread before browser main loop to start" This is a reland of I23ef57eb52bfb1eb363682dadf98c571c12afcd1. It was reverted in Ia548067acbf640010f4c8fbed29a0012a274af05. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 557680 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5NTUwMWZiMjllM2U3NDg3ZmZmOThjMTdlNmFhYmExMDQ2YjMzMAw The data race has been fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/1064450. Original change's description: > Create BrowserThread::IO thread before browser main loop to start > ServiceManager. > > We need a thread to post/execute tasks when starting the > ServiceManager. This thread needs to be created before the browser > main loop is initialized, and will be registered as the > BrowserThread::IO thread which is currently used by ServiceManager > connections. > > The creation of such a thread is moved to service_manager::main via > MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no > thread created before calling fork() on posix, we also move the setup > of sandbox before creating the IO thread. > > Bug: 740677, 729596 > Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 > Reviewed-on: https://chromium-review.googlesource.com/969098 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557680} Bug: 740677, 729596 Change-Id: I9afb0cdc0f11a1d437c2e9bd09c374503c3d5a4b Reviewed-on: https://chromium-review.googlesource.com/1059949 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560724}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .