Google Git
Sign in
chromium / chromium / src.git / fb1db293b96c552b50f7815788fee281af0f0c93
commitfb1db293b96c552b50f7815788fee281af0f0c93[log] [tgz]
authorHayato Ito <hayato@chromium.org>Thu Oct 23 07:11:46 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 23 07:11:46 2025
tree7726ab5b4deb20e221acb7a7b492c77565ca05ab
parent21bf2905a8cfbd73bf16fecfe5d05b47934ab1b3 [diff]
Fix a crash in HttpNetworkTransaction::PopulateLoadTimingInternalInfo

This fix is similar to previous ones for CreateStream [^1] and
ConnectedCallback [^2], but it addresses an issue in DoInitStream.

The underlying cause is that `initialize_stream_end_time_` is not being
cleared, even though `DoInitStream()` can be called multiple times. This
could lead to a crash later when populating `LoadTimingInternalInfo` at
the following check [^3]:

```
CHECK_LE(initialize_stream_start_time_, initialize_stream_end_time_);
```

This is a speculative fix, as I was unable to reproduce the crash
locally.

[^1]: https://crrev.com/c/6433371
[^2]: https://crrev.com/c/6434248
[^3]:
https://crash.corp.google.com/browse?q=product_name+IN+%28%27Chrome%27%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27net%3A%3AHttpNetworkTransaction%3A%3APopulateLoadTimingInternalInfo%27+AND+ChromeMilestone%28product.Version%29%3D143&stbtiq=&reportid=&index=0#4

Bug: 408060617
Change-Id: Ifb064bb31cee0af9300a3fa592710f3b7753a776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7077858
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1534117}
1 file changed
tree: 7726ab5b4deb20e221acb7a7b492c77565ca05ab
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. clusterfuzz-data
  52. internal
  53. ios_internal
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .cursorignore
  60. .geminiignore
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. SECURITY_OWNERS
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.