commit | 7a07ae38bc0ff0823f5d518d3cdc68c68939049f | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Fri May 10 18:29:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 10 18:29:01 2019 |
tree | 8157c2072bfbde261d2c69a99459a1496ae5e02d | |
parent | fd0c617e1c18910468c19cf6c59f60eb4166d97a [diff] |
[Editing] Reorganize code for visual up/down caret movements PreviousLinePosition() and NextLinePosition() are subroutines of SelectionModifier and only used there. Hence, this patch moves the two functions, together with their helper functions, to selection_modifier_line.cc for better code structure. This is also preparation for implementing hit test based up and down caret movements. Note: One VisibleUnitLineTest tests an exposed subroutine of PreviousLinePosition, which is inappropriate. This patch changes it to test up caret movement instead. Bug: 950728 Change-Id: Ia8a59e8de4bef53c5b4708c59e6995c9d6021687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603211 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658668}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .