commit | 8067ccd6ca20a74011bb06c60b08c40343fc0f19 | [log] [tgz] |
---|---|---|
author | Zhongyi Shi <zhongyi@chromium.org> | Wed Nov 20 06:32:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 20 06:32:09 2019 |
tree | 856c12aa181fba07b8efab564832ce30ba21dd6f | |
parent | eee0a0b89a0ce6c93f03b98be42229f610cc012e [diff] |
Revert "[promises] Make sure alignas value is compatible with heap allocations" This reverts commit eb4de73982101ad8b6979d4b0a3fda2123d01399. Reason for revert: breaks ios.cronet builder https://ci.chromium.org/p/chrome/builders/ci/cronet-ios Original change's description: > [promises] Make sure alignas value is compatible with heap allocations > > Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make > sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations. > > For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61 > > Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Carlos Caballero <carlscab@google.com> > Cr-Commit-Position: refs/heads/master@{#714395} TBR=gab@chromium.org,thakis@chromium.org,alexclarke@chromium.org,carlscab@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idbdb94a682ceb855a53b6108005d8fed57595ce3 Bug: 1026037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925776 Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#716881}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .