Google Git
Sign in
chromium / chromium / src.git / 84cbd27f57ae5850b81c836fe899e6a4d3a005b9
commit84cbd27f57ae5850b81c836fe899e6a4d3a005b9[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Tue Aug 28 07:50:02 2018
committerCommit Bot <commit-bot@chromium.org>Tue Aug 28 07:50:02 2018
tree574e120e1cbef309f769c3c37efc59ae07205ee5
parenta1e7bace79b380b59682f664de1c6b633876a9ca [diff]
[LayoutNG] Set kDontReshapeStart correctly when rewinding

NGLineBreaker::BreakText sets kDontReshapeStart for the items
at the beginning of a line.

This patch fixes to compute it by whether the start offset of
the item_result is at the beginning, not the current offset
NGLinebreaker is reading at. They are the same for the normal
line breaking, but not so when rewinding.

Found while investigating crbug.com/866771.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I812d2cd44492a0112bcd037749168e8eb62d8a94
Reviewed-on: https://chromium-review.googlesource.com/1190983
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586615}
1 file changed
tree: 574e120e1cbef309f769c3c37efc59ae07205ee5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .