Google Git
Sign in
chromium / chromium / src.git / 8e450d68b56727446323d34770f997ce468247df
commit8e450d68b56727446323d34770f997ce468247df[log] [tgz]
authorJinsuk Kim <jinsukkim@chromium.org>Wed Sep 04 02:56:20 2019
committerCommit Bot <commit-bot@chromium.org>Wed Sep 04 02:56:20 2019
treea6c2a85c5eb208b8c260511c2824574275f9c127
parente54fc640d6df4106d5522a263debcacf2efc3b5d [diff]
Android: Handle gesture navigation favicon callback invoked too late

Favicon callbacks can be invoked after the navigation sheet is already
closed. There is a null check against |mModelList| but it never
becomes null. Its state should have been checked instead. This CL
checks such case correctly.

Bug: 1000220
Change-Id: I724b7c3a7d79e36a99d6c102849312e8010f2548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783680
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692988}
1 file changed
tree: a6c2a85c5eb208b8c260511c2824574275f9c127
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .