Google Git
Sign in
chromium / chromium / src.git / 8e450d68b56727446323d34770f997ce468247df
commit8e450d68b56727446323d34770f997ce468247df[log] [tgz]
authorJinsuk Kim <jinsukkim@chromium.org>Wed Sep 04 02:56:20 2019
committerCommit Bot <commit-bot@chromium.org>Wed Sep 04 02:56:20 2019
treea6c2a85c5eb208b8c260511c2824574275f9c127
parente54fc640d6df4106d5522a263debcacf2efc3b5d [diff]
Android: Handle gesture navigation favicon callback invoked too late

Favicon callbacks can be invoked after the navigation sheet is already
closed. There is a null check against |mModelList| but it never
becomes null. Its state should have been checked instead. This CL
checks such case correctly.

Bug: 1000220
Change-Id: I724b7c3a7d79e36a99d6c102849312e8010f2548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783680
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692988}
1 file changed
tree: a6c2a85c5eb208b8c260511c2824574275f9c127
  1. .clang-format
  2. .eslintrc.js
  3. .git-blame-ignore-revs
  4. .gitattributes
  5. .gitignore
  6. .gn
  7. .vpython
  8. AUTHORS
  9. BUILD.gn
  10. CODE_OF_CONDUCT.md
  11. DEPS
  12. ENG_REVIEW_OWNERS
  13. LICENSE
  14. LICENSE.chromium_os
  15. OWNERS
  16. PRESUBMIT.py
  17. PRESUBMIT_test.py
  18. PRESUBMIT_test_mocks.py
  19. README.md
  20. WATCHLISTS
  21. android_webview/
  22. apps/
  23. ash/
  24. base/
  25. build/
  26. build_overrides/
  27. buildtools/
  28. cc/
  29. chrome/
  30. chromecast/
  31. chromeos/
  32. cloud_print/
  33. codereview.settings
  34. components/
  35. content/
  36. courgette/
  37. crypto/
  38. dbus/
  39. device/
  40. docs/
  41. extensions/
  42. fuchsia/
  43. gin/
  44. google_apis/
  45. google_update/
  46. gpu/
  47. headless/
  48. infra/
  49. ios/
  50. ipc/
  51. jingle/
  52. media/
  53. mojo/
  54. native_client_sdk/
  55. net/
  56. pdf/
  57. ppapi/
  58. printing/
  59. remoting/
  60. rlz/
  61. sandbox/
  62. services/
  63. skia/
  64. sql/
  65. storage/
  66. styleguide/
  67. testing/
  68. third_party/
  69. tools/
  70. ui/
  71. url/
  72. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .