Google Git
Sign in
chromium / chromium / src.git / 9ccef9afbe403454161a863409ba9323afe67285
commit9ccef9afbe403454161a863409ba9323afe67285[log] [tgz]
authorRayan Kanso <rayankans@chromium.org>Thu Jan 10 20:18:15 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 10 20:18:15 2019
treea707bf4dd7be0273cff2c6b2face42aac235fdad
parentc7f27a456b8d0e906969d1c8e7c14fc500700977 [diff]
[Background Fetch] Keep Job Details in memory until safe to erase

The Job Details were being deleted in the delegate after the event was
dispatched, which broke the click event. This change keeps the details
around until after the last click event, since currently there is no way
to figure out whether the notification still exists or not.

Change-Id: Ia43534b763d5039ee8bffa153899aee4b706132c
Reviewed-on: https://chromium-review.googlesource.com/c/1401063
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621724}
3 files changed
tree: a707bf4dd7be0273cff2c6b2face42aac235fdad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .