| commit | 9d6b0dd8dc0ca9364cc74fe5df855466bb15ef67 | [log] [tgz] |
|---|---|---|
| author | Julie Jeongeun Kim <jkim@igalia.com> | Thu Jan 21 04:06:11 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 21 04:06:11 2021 |
| tree | 48abf57d783516885fc2c750caba5b10b3a4c260 | |
| parent | 40a177993db43af0478ce7ac19ed9cbf40301d10 [diff] |
Deprecate ResourceType in //components/safe_browsing
This CL replaces blink::mojom::ResourceType with
network::mojom::RequestDestination in
//components/safe_browsing since blink::mojom::ResourceType
is deprecated[1].
This change
- Renames CanCheckResourceType() to CanCheckRequestDestination()
in SafeBrowsingDatabaseManager.
- Replaces |resource_type_| with |request_destination_| in
SafeBrowsingUrlCheckerImpl.
- Updates CreateCheckerAndCheck() in mojom:: SafeBrowsing to get
network.mojom.RequestDestination instead of
blink.mojom.ResourceType.
- Replaces |resource_type| with |request_destination| in
security_interstitials::UnsafeResource.
- Introduces GetResourceTypeFromRequestDestination() for UMA logging
in order to keep reporting with ResourceType.
[1] https://crbug.com/960143
Bug: 1059639
Change-Id: I5e35999a3a71c77dc2ab8df0c7ff71d62ec6319c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589575
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#845507}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.