commit | 9fc031ebdeade7ee64e065f78ec823f4983bfc43 | [log] [tgz] |
---|---|---|
author | Charles Harrison <csharrison@chromium.org> | Mon Oct 02 12:05:30 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 02 12:05:30 2017 |
tree | ff787a4f87bf5d5434ab9f50373bccb38eb534bb | |
parent | 6a986948a587cc5a45db73984329ee56d669a058 [diff] |
Popup metrics: add popup opener specific metrics This patch adds two new metrics. 1. A breakout metric of our "VisibleTimeAfterCrossOriginRedirect" metric, which measures the visible time for tabs that also have opened a popup before doing the redirect. 2. The amount of time between the popup -> redirect. These metrics will help us evaluate how valuable tab-unders are to users. This patch also adds some infrastructure for noting opener <-> popup relationships between the popup_opener_tab_helper and the popup_tracker. This information is not used all that much in this patch, but will be critical in future patches if we want to intervene on tab-unders. This added infrastructure caught a bug where we were considering WebContents that had no opener to be a popup. This is amended and tested in this patch, and the PopupTracker metric is versioned. Bug: 661629 Change-Id: I4109333d3f689a03de3b4aaa6f5310c8a861fb09 Reviewed-on: https://chromium-review.googlesource.com/690297 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#505585}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .