Google Git
Sign in
chromium / chromium / src.git / a0f301ad19908c1320f0b00d87f0469b6009b5a6
commita0f301ad19908c1320f0b00d87f0469b6009b5a6[log] [tgz]
authorDonna Wu <donna.wu@intel.com>Wed Sep 12 07:16:20 2018
committerCommit Bot <commit-bot@chromium.org>Wed Sep 12 07:16:20 2018
treea73658bd6df39df1d1d4f31060e2e5d981da304e
parentdc958253ea2fd3227ed0422aaa1928733199fb79 [diff]
Listen to UsbDeviceManager instead of UsbService in UsbChooserContext.

For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled
after "OnDeviceRemoved". But for mojom interface UsbDeviceManager,
there is no way to provide such dependency among listeners.

As all users will be converted from UsbService to UsbDeviceManager,
to avoid the potential race condition, WebUsbServiceImpl is made
listen to UsbChooserContext in this CL.

Bug: 699790
Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b
Reviewed-on: https://chromium-review.googlesource.com/1210386
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590609}
11 files changed
tree: a73658bd6df39df1d1d4f31060e2e5d981da304e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .