commit | b1e4803dd916d499f16209589ff06a0745a8e474 | [log] [tgz] |
---|---|---|
author | Scott Violet <sky@chromium.org> | Thu Dec 06 18:22:31 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 06 18:22:31 2018 |
tree | 1f687a370898364fe455246b75b994d689a0d5e0 | |
parent | e908ae1d722150daddb6a3074842d564e29b6694 [diff] |
chromeos: refactor LockWindow LockWindow is used from both chrome and ash. LockWindow reaches directly into ash and parents a widget to ash's hierarchy. This won't work from the chrome side. The code has been refactored in two ways: . ash specific functionality has been moved into LockLayoutManager. . a factory function for creating the widget is added to ash/public/cpp. The function takes an argument that dictates how it works. Specifically in ash code the parent is supplied, outside of ash the container id is used. BUG=899862 TEST=covered by tests Change-Id: I4c0ca9c91948df9f653f5cb97bb6bc1c48c09301 Reviewed-on: https://chromium-review.googlesource.com/c/1364076 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#614420}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .