blob: c95452bb7721cfd65f6f2fb2c31ab9f07eb8f324 [file] [log] [blame]
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "base/bind.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/memory/ref_counted.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/chrome_zipfile_installer.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/load_error_reporter.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/test/base/testing_profile.h"
#include "components/services/unzip/content/unzip_service.h"
#include "components/services/unzip/in_process_unzipper.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "services/data_decoder/public/cpp/test_support/in_process_data_decoder.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
#include "chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.h"
#endif
namespace extensions {
namespace {
struct MockExtensionRegistryObserver : public ExtensionRegistryObserver {
void WaitForInstall(bool expect_error) {
extensions::LoadErrorReporter* error_reporter =
extensions::LoadErrorReporter::GetInstance();
error_reporter->ClearErrors();
while (true) {
base::RunLoop run_loop;
// We do not get a notification if installation fails. Make sure to wake
// up and check for errors to get an error better than the test
// timing-out.
// TODO(jcivelli): make LoadErrorReporter::Observer report installation
// failures for packaged extensions so we don't have to poll.
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(),
base::TimeDelta::FromMilliseconds(100));
quit_closure = run_loop.QuitClosure();
run_loop.Run();
const std::vector<base::string16>* errors = error_reporter->GetErrors();
if (!errors->empty()) {
if (!expect_error) {
FAIL() << "Error(s) happened when unzipping extension: "
<< (*errors)[0];
}
break;
}
if (!last_extension_installed.empty()) {
// Extension install succeeded.
EXPECT_FALSE(expect_error);
break;
}
}
}
void OnExtensionInstalled(content::BrowserContext* browser_context,
const Extension* extension,
bool is_update) override {
last_extension_installed = extension->id();
quit_closure.Run();
}
std::string last_extension_installed;
base::Closure quit_closure;
};
struct UnzipFileFilterTestCase {
const base::FilePath::CharType* input;
const bool should_unzip;
};
} // namespace
class ZipFileInstallerTest : public testing::Test {
public:
ZipFileInstallerTest()
: task_environment_(content::BrowserTaskEnvironment::IO_MAINLOOP) {}
void SetUp() override {
extensions::LoadErrorReporter::Init(/*enable_noisy_errors=*/false);
in_process_utility_thread_helper_.reset(
new content::InProcessUtilityThreadHelper);
unzip::SetUnzipperLaunchOverrideForTesting(
base::BindRepeating(&unzip::LaunchInProcessUnzipper));
// Create profile for extension service.
profile_.reset(new TestingProfile());
TestExtensionSystem* system =
static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile_.get()));
extension_service_ = system->CreateExtensionService(
base::CommandLine::ForCurrentProcess(), base::FilePath(), false);
ExtensionRegistry* registry(ExtensionRegistry::Get(profile_.get()));
registry->AddObserver(&observer_);
}
void TearDown() override {
// Need to destruct ZipFileInstaller before the message loop since
// it posts a task to it.
zipfile_installer_ = NULL;
ExtensionRegistry* registry(ExtensionRegistry::Get(profile_.get()));
registry->RemoveObserver(&observer_);
profile_.reset();
unzip::SetUnzipperLaunchOverrideForTesting(base::NullCallback());
base::RunLoop().RunUntilIdle();
}
void RunInstaller(const std::string& zip_name, bool expect_error) {
base::FilePath original_path;
ASSERT_TRUE(base::PathService::Get(chrome::DIR_TEST_DATA, &original_path));
original_path = original_path.AppendASCII("extensions")
.AppendASCII("zipfile_installer")
.AppendASCII(zip_name);
ASSERT_TRUE(base::PathExists(original_path)) << original_path.value();
zipfile_installer_ = ZipFileInstaller::Create(
MakeRegisterInExtensionServiceCallback(extension_service_));
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(&ZipFileInstaller::LoadFromZipFile,
zipfile_installer_, original_path));
observer_.WaitForInstall(expect_error);
}
void RunZipFileFilterTest(
const std::vector<UnzipFileFilterTestCase>& cases,
base::RepeatingCallback<bool(const base::FilePath&)>& filter) {
for (size_t i = 0; i < cases.size(); ++i) {
base::FilePath input(cases[i].input);
bool observed = filter.Run(input);
EXPECT_EQ(cases[i].should_unzip, observed)
<< "i: " << i << ", input: " << input.value();
}
}
protected:
scoped_refptr<ZipFileInstaller> zipfile_installer_;
std::unique_ptr<TestingProfile> profile_;
ExtensionService* extension_service_;
content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<content::InProcessUtilityThreadHelper>
in_process_utility_thread_helper_;
MockExtensionRegistryObserver observer_;
#if defined(OS_CHROMEOS)
chromeos::ScopedCrosSettingsTestHelper cros_settings_test_helper_;
// ChromeOS needs a user manager to instantiate an extension service.
chromeos::ScopedTestUserManager test_user_manager_;
#endif
private:
data_decoder::test::InProcessDataDecoder in_process_data_decoder_;
};
TEST_F(ZipFileInstallerTest, GoodZip) {
RunInstaller("good.zip", /*expect_error=*/false);
}
TEST_F(ZipFileInstallerTest, BadZip) {
// Manifestless archive.
RunInstaller("bad.zip", /*expect_error=*/true);
}
TEST_F(ZipFileInstallerTest, ZipWithPublicKey) {
RunInstaller("public_key.zip", /*expect_error=*/false);
const char kIdForPublicKey[] = "ikppjpenhoddphklkpdfdfdabbakkpal";
EXPECT_EQ(observer_.last_extension_installed, kIdForPublicKey);
}
TEST_F(ZipFileInstallerTest, NonTheme_FileExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("foo"), true},
{FILE_PATH_LITERAL("foo.nexe"), true},
{FILE_PATH_LITERAL("foo.dll"), true},
{FILE_PATH_LITERAL("foo.jpg.exe"), false},
{FILE_PATH_LITERAL("foo.exe"), false},
{FILE_PATH_LITERAL("foo.EXE"), false},
{FILE_PATH_LITERAL("file_without_extension"), true},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::ShouldExtractFile, false);
RunZipFileFilterTest(cases, filter);
}
TEST_F(ZipFileInstallerTest, Theme_FileExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("image.jpg"), true},
{FILE_PATH_LITERAL("IMAGE.JPEG"), true},
{FILE_PATH_LITERAL("test/image.bmp"), true},
{FILE_PATH_LITERAL("test/IMAGE.gif"), true},
{FILE_PATH_LITERAL("test/image.WEBP"), true},
{FILE_PATH_LITERAL("test/dir/file.image.png"), true},
{FILE_PATH_LITERAL("manifest.json"), true},
{FILE_PATH_LITERAL("other.html"), false},
{FILE_PATH_LITERAL("file_without_extension"), true},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::ShouldExtractFile, true);
RunZipFileFilterTest(cases, filter);
}
TEST_F(ZipFileInstallerTest, ManifestExtractionFilter) {
const std::vector<UnzipFileFilterTestCase> cases = {
{FILE_PATH_LITERAL("manifest.json"), true},
{FILE_PATH_LITERAL("MANIFEST.JSON"), true},
{FILE_PATH_LITERAL("test/manifest.json"), false},
{FILE_PATH_LITERAL("manifest.json/test"), false},
{FILE_PATH_LITERAL("other.file"), false},
};
base::RepeatingCallback<bool(const base::FilePath&)> filter =
base::BindRepeating(&ZipFileInstaller::IsManifestFile);
RunZipFileFilterTest(cases, filter);
}
} // namespace extensions