commit bde87c12b753215a2de5eaf0a37dec93884a20d9
author Lutz Justen <ljusten@chromium.org> Tue May 21 14:52:39 2019
committer Commit Bot <commit-bot@chromium.org> Tue May 21 14:52:39 2019
tree 17e3596e79ecf4aa1da641c194558446ad4ff146
parent 13dce9f8b46c71db2ef5f8412d58d16e74f388b8

Reland "Reland "Add dialog to add Kerberos accounts""

This reverts commit 6244e906abfb3fbcf7378e851c61c94281375e75.

Reason for revert: Fix test for real this time (reland + CL:1621130).

Original change's description:
> Revert "Reland "Add dialog to add Kerberos accounts""
> 
> This reverts commit 42829c6bdd21166e68e442125d4fa7b6a3f54ea8.
> 
> Reason for revert: The test is still broken
> 
> Original change's description:
> > Reland "Add dialog to add Kerberos accounts"
> > 
> > This reverts commit 3335a8014fc0e67cffc3a5c48ff2cc251c31a500.
> > 
> > Reason for revert: Fixed the test (see diff PS1 - PS2).
> > 
> > Original change's description:
> > > Revert "Add dialog to add Kerberos accounts"
> > >
> > > This reverts commit 3f0c9943a5b4d5e2fdfdf321e39b027f04c105c1.
> > >
> > > Reason for revert: Broke CrSettingsPeoplePageKerberosAccountsTest.All on linux-chromeos-dbg. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12486 for first failing build.
> > >
> > > Original change's description:
> > > > Add dialog to add Kerberos accounts
> > > >
> > > > Adds a Chrome OS-only dialog to add Kerberos accounts and displays it
> > > > in the Kerberos Accounts settings page when the 'Add account' button
> > > > is clicked there. The dialog is functional, but needs further polish
> > > > and UX review.
> > > >
> > > > The functionality is guarded by the KerberosEnabled policy (off by
> > > > default, cannot be enabled so far except for dev purposes).
> > > >
> > > > BUG=chromium:952238
> > > > TEST=Turn on KerberosEnabled policy, e.g. in YAPS or with a json file on
> > > >      the DUT in /etc/opt/chrome/policies/managed/ with contents
> > > >        { "KerberosEnabled": true }
> > > >      (requires writeable rootfs). Note that there's no admin console UI
> > > >      yet. On Chromebook, navigate to chrome:settings/kerberosAccounts,
> > > >      click Add account. Verify that the 'Add Kerberos Account' dialog
> > > >      opens. You might be able to log in with an Active Directory account
> > > >      (e.g. chromeadm-lab.com), but at the time of writing the Kerberos
> > > >      system daemon is not ready, so you should see some error.
> > > >
> > > > Change-Id: I94c07c8cbbb59c9b4153929c88a534a9a36210f6
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596427
> > > > Commit-Queue: Lutz Justen <ljusten@chromium.org>
> > > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#661355}
> > >
> > > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org
> > >
> > > Change-Id: Ic5615c3ab21cef87bb707d60fabeb7e6fc033815
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:952238
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621467
> > > Reviewed-by: Fergus Dall <sidereal@google.com>
> > > Commit-Queue: Fergus Dall <sidereal@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#661542}
> > 
> > TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com
> > 
> > Change-Id: Ie24a3aad23924f85d29902aebfe35cd7b63f6a50
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:952238
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620628
> > Reviewed-by: Lutz Justen <ljusten@chromium.org>
> > Commit-Queue: Lutz Justen <ljusten@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#661646}
> 
> TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,sidereal@google.com
> 
> Change-Id: I23559808c98200730271493c72d028cd58f4ee37
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:952238
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621034
> Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#661711}

TBR=stevenjb@chromium.org,dpapad@chromium.org,ljusten@chromium.org,mbarowsky@chromium.org,sidereal@google.com

Change-Id: I37ced4409351bceda9648c46b79608fe04ba2fa9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:952238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621137
Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661721}