Revert "Do not show a bad flags warning for performance testing."
This reverts commit 33b13b2f44690f0ec7b7c8da241d69efad9aa0e3.
Reason for revert: See crbug.com/825082
Original change's description:
> Do not show a bad flags warning for performance testing.
>
> crrev.com/c/956654 introduced the bad flags warning of "stability and
> security will suffer" for Android.
> This change caused parformance regressions because a bad flag
> "--ignore-certificate-errors-spki-list" is used for perfomance testing.
> (crbug.com/822258#c13)
>
> So this cl introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt().
> This check already exists in startup_browser_creator_impl.cc for Desktop not
> to show the infobar during performance tests.
>
> crrev.com/c/catapult/+/965712 will add the flag in the script of catapult.
>
> Bug: 822258,803774
> Change-Id: Icef23b907460f3a60284675f1dd2f55a73375b72
> Reviewed-on: https://chromium-review.googlesource.com/965727
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544206}
TBR=horo@chromium.org,bauerb@chromium.org,kouhei@chromium.org,tmartino@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 822258, 803774
Change-Id: I2cf5a09ab6520938ffcd74c897c0b5dd17516f57
Reviewed-on: https://chromium-review.googlesource.com/977142
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545375}diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc b/chrome/browser/ui/startup/bad_flags_prompt.cc
index cb6e286..a18b767 100644
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
@@ -119,14 +119,6 @@
} // namespace
void ShowBadFlagsPrompt(content::WebContents* web_contents) {
- // Do not show a warning of "stability and security will suffer" when the
- // browser is being controlled by automated tests, so that it doesn't
- // interfere with tests that assume no info bars.
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableAutomation)) {
- return;
- }
-
// Flags only available in specific builds, for which to display a warning
// "the flag is not implemented in this build", if necessary.
struct {
