Google Git
Sign in
chromium / chromium / src.git / c5243b13dea02526aeab39457f8ff09f2eb385f2
commitc5243b13dea02526aeab39457f8ff09f2eb385f2[log] [tgz]
authorXiaocheng Hu <xiaochengh@chromium.org>Tue May 21 21:45:23 2019
committerCommit Bot <commit-bot@chromium.org>Tue May 21 21:45:23 2019
tree19c53487fea127050bf68c081f28b3afd168af16
parente57879d1dee429cb7fff1656e7251cfa7f94c4b9 [diff]
[LayoutNG] Stop asserting position validity in ComputeNGCaretPosition

The assertion was added when ComputeNGCaretPosition had a very limited
usage before. Now that it can be entered more often, and can be called
even on legacy layout (from ComputeContainingLineBoxOf(), which returns
null on legacy), the assertion no longer makes sense.

Hence, this patch removes the assertion.

Bug: 965518
Change-Id: Ibf64b23b5249c0af1935c12606527335d5f8101f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622867
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661919}
1 file changed
tree: 19c53487fea127050bf68c081f28b3afd168af16
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .