commit c721c7cddaa61e28a360f5942682d7417fc7c5c9
author Vaclav Brozek <vabr@chromium.org> Thu Nov 30 14:30:29 2017
committer Commit Bot <commit-bot@chromium.org> Thu Nov 30 14:30:29 2017
tree 2b8efabdbc5565b87b559d608aa02ce2a606d255
parent 2a14f5924fb59c694afdcc3114727f2b6eacef5f

[Android password settings] Separate reauthentication helper

Currently the logic for reauthentication is scattered over these files:

PasswordEntryEditor.java
SavePasswordsPreferences.java

where SavePasswordsPreferences take care of resetting and own the
timer for reauthentication validity (because it should be tied to the
passwords settings lifetime), and PasswordEntryEditor contains logic
to decide about reauthentication steps based on that timer and on
other device state.

This alone is already a little disorganised. In a follow-up CL, one
more callsite for the reauth logic will be added, in
SavePasswordsPreferences.java, meaning that there would be
difficulties reusing the code currently in PasswordEntryEditor.java.

For that reason, this CL introduces a new class,
ReauthenticationManager.java, which encapsulates the logic. Because
the timer has been a static value, the new class is also composed of
static methods.

Bug: 788701
Change-Id: Iea2007fdd9c89bff77595b2cf5ea8ac4e1501792
Reviewed-on: https://chromium-review.googlesource.com/797510
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520536}