commit cfe37a2b26a025c52e6cd399d7a58e9860ef57a5
author Jacobo Aragunde Pérez <jaragunde@igalia.com> Mon Nov 19 11:36:15 2018
committer Commit Bot <commit-bot@chromium.org> Mon Nov 19 11:36:15 2018
tree 6cbc40ceecb9021750848b04fc125a5aa8872257
parent 899f175b65c31a537ad83400ae85a7f2d93e8703

Fix flaky WebViewTest.SpatialNavigationJavascriptAPI.

Two reasons for flakiness were identified:

* Occasional lack of sync between the C++ and JS sides of the test.
Sometimes, the JS side emitted signals before the C++ code was ready to
listen to them, or the C++ side emitted keystrokes before listeners were
ready in JS code. Fixed with slight changes in the order of the test
code.

* When checking the spatial navigation status immediately after changing
it, the wrong state could be reported. When the system is under heavy
load, it could happen that the changed state is reported before the
change has been made effective in the render process. Fixed sending a
message to the guest render process with postMessage, which uses the
same IPC channel; when the message is answered we can be sure that the
SetSpatialNavigationEnabled operation is complete.

Bug: 884306
Change-Id: Iae227098cd36980357d8b747ddcb527df2317fa1
Reviewed-on: https://chromium-review.googlesource.com/c/1327204
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Cr-Commit-Position: refs/heads/master@{#609241}