Chrome Cleanup: make the reporting preference a protected profile pref

In https://chromium-review.googlesource.com/c/chromium/src/+/1373888 we
made the "software_reporter.reporting" pref into a real preference.
We consider that this preference should be protected through Secure
Preferences. However, the Local State file does not have a Secure Pref
equivalent. This change moves the software_reporter.reporting pref out
of Local State, instead adding it to the user's preferences.

Migration of the pref is not needed assuming this CL lands shortly
after https://chromium-review.googlesource.com/c/chromium/src/+/1373888,
as the Local State pref was not user-modifiable prior to that change;
the pref was used solely to allow enterprise policies to disable the
reporting of the Chrome Cleanup Tool.

Bug: 866539
Change-Id: Icbf83b7647b5c735f3f09962327f2ffdaa441e40
Reviewed-on: https://chromium-review.googlesource.com/c/1379029
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617560}
13 files changed