Google Git
Sign in
chromium / chromium / src.git / dae005d6f08835613c1e3c9ec39c370625b6236b
commitdae005d6f08835613c1e3c9ec39c370625b6236b[log] [tgz]
authorEmil A Eklund <eae@chromium.org>Wed May 15 00:09:06 2019
committerCommit Bot <commit-bot@chromium.org>Wed May 15 00:09:06 2019
tree555bb9b01db65c68e0adc18c65f0dbf5bcd9693f
parent68d2ad49d1979ae00994970c0240ed7d931cc9b5 [diff]
[LayoutNG] Handle ellipsis for empty vertical-rl

Fix bug in NGLineTruncator::TruncateChild where it incorrectly assumes a
fragment always has content. This isn't always the case, especially when
obscure -webkit features are used. This change adds an extra null check.

Not using a WPT test as the test case replies on impl specific behavior.

Bug: 962297, 962471
Change-Id: I87ac7841a93303802aa2028e0ee04aaa9ab0961d
Test: web_tests/fast/text/empty-ellipsis-vertical-rl-crash.html
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612224
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659740}
3 files changed
tree: 555bb9b01db65c68e0adc18c65f0dbf5bcd9693f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .