Google Git
Sign in
chromium / chromium / src.git / dc4f172dfe2167666aff966b119181c57639e46d
commitdc4f172dfe2167666aff966b119181c57639e46d[log] [tgz]
authorsangwoo.ko <sangwoo108@gmail.com>Fri Feb 16 22:49:46 2018
committerCommit Bot <commit-bot@chromium.org>Fri Feb 16 22:49:46 2018
tree09787bf752b1bfd802810d92f714d5e3d25733ee
parent0a29b20ea9f2b1e02b76412f233321348889b7c0 [diff]
Try saving pinned tabs on OnBrowserRemoved

Bug:71939

PinnedTabService is observing two events:
NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and BrowserList::OnBrowserClosing.

The first is when users want to shut down entire app and
the latter is when users close a browser at once even if it has multiple tabs.

But the bug is edge case which doesn't belong to any case above for now.
When tab strip is empty, BrowserListObserver::OnBrowserClosing is not called even
this will end up with closing the browser.

So try saving pinned tabs again on BrowserListObserver::OnBrowserRemoved.

Change-Id: Id73891b9509918bca3b1dcaf0b34cc32a7a687a7
Test: PinnedTabServiceBrowserTest.*
Reviewed-on: https://chromium-review.googlesource.com/892539
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537442}
4 files changed
tree: 09787bf752b1bfd802810d92f714d5e3d25733ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .