commit | 3ac7158dcf47b20b73fa5bb89c76604490e5b855 | [log] [tgz] |
---|---|---|
author | Maksym Onufriienko <monufriienko@chromium.org> | Mon Jun 17 23:48:15 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 17 23:48:15 2019 |
tree | 08bd131b18c646f800c571b92bec52aa972c5c87 | |
parent | 6580cbdf7891f831005da7bf5f1bb90c375b4dab [diff] |
Converted `base::FeatureList::IsEnabled` to EG2 C_E_G methods. This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes. Chrome App can be launched with specific feature flags. Chrome Test should be able to query the value of specific flags from Chrome App. Chrome Test can't use base::FeatureList::IsEnabled(), because base::Feature value is not in sync with Chrome App. This CL builds infrastructure for Chrome Test to query value of specific flags from Chrome App. As `base::FeatureList::IsEnabled` won't compile under EG2, added C_E_G methods that will just call ChromeEarlGreyAppInterface methods: - (BOOL)[ChromeEarlGrey isSlimNavigationManagerEnabled] - (BOOL)[ChromeEarlGrey isCompactTranslateInfobarIOSEnabled] - (BOOL)[ChromeEarlGrey isBlockNewTabPagePendingLoadEnabled] - (BOOL)[ChromeEarlGrey isUmaCellularEnabled] - (BOOL)[ChromeEarlGrey isUKMEnabled] - (BOOL)[ChromeEarlGrey isWebPaymentsModifiersEnbaled] # Require for ios_intertnal/external_url_omnibox_popup_egtest.mm # https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1357283 - (BOOL)[ChromeEarlGrey isNewOmniboxPopupLayoutEnabled] As there is no way to pass `base::Feature` parameter to ChromeEarlGreyAppInterface, its methods will be 1:1 match to E_C_G, e.g. BOOL isSlimNavigationManagerEnabled { return [ChromeEarlGreyAppInterface isSlimNavigationManagerEnabled]; } Bug: 922813 Change-Id: I8da1e3fa318ca3de8ad40c4df3cf181c6aa7845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639138 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#669904}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .