Google Git
Sign in
chromium / chromium / src.git / e8f196c8b6b4e975c52cffb6b9a48c9d6df2c9f7
commite8f196c8b6b4e975c52cffb6b9a48c9d6df2c9f7[log] [tgz]
authorPeter Boström <pbos@chromium.org>Sat Feb 16 04:40:41 2019
committerCommit Bot <commit-bot@chromium.org>Sat Feb 16 04:40:41 2019
treeb33686a252215c253f09ccd4c332f11d0af93cac
parent97a466e5d64f4c6ec73df36da3ec0d4a88cfc3f8 [diff]
Observe InkDrop focus changes through ViewObserver

This is less brittle than the existing mechanism since we don't need
child classes' overrides of OnFocus/OnBlur to call their parent's.
FocusRing already works by observing host focus / blur so this brings
the implementations closer together.

Unfortunately this can't easily be added directly to InkDropImpl since
the InkDrop is lazily created by, for instance, changes in focus.
Creating the InkDrop in the constructor does not work as virtual calls
do not propagate to child classes until they are constructed.

Bug: chromium:931964
Change-Id: I9d490b0368d818cac258913f8426f5e63609963d
Reviewed-on: https://chromium-review.googlesource.com/c/1475162
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632913}
2 files changed
tree: b33686a252215c253f09ccd4c332f11d0af93cac
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .