commit | ed44fc45d0c3b3675efec4c550d28c5de1569c9d | [log] [tgz] |
---|---|---|
author | Yuri Wiitala <miu@chromium.org> | Sat Dec 15 03:14:24 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Dec 15 03:14:24 2018 |
tree | 609e1899b0dce2bf16bceb8a989a148659d5ec15 | |
parent | 4c40f61f89ae4d0a196c2c7b14b696bb7b5e0430 [diff] |
Complete the screen capture color space plumbing. Adds all remaining "plumbing" of color space information, throughout the CopyOutputRequest execution pipeline and the FrameSinkVideoCapturer pipeline. This ensures the color space being used to draw the original RenderPass within the compositor is being specified in the metadata for all result images. DevTools: Remove a hack from the color picker tool, now that the color space information for the screen capture frame is being provided. browser_tests/content_browsertests changes: Multilple browser tests were fixed as a result of this change revealing pre-existing bugs in the tests: the web page layout of the color regions, how pixels were being selected for analysis, and YUV→RGB color space conversion inaccuracies. Blink layout tests: Rebased a number of layout test expectations, as the the layout tests utilize the screen capture pipeline. I examined all of these changed expectations to confirm near 0% change: Meaning that just a tiny number of pixels in an image were imperceivably different because of adding the missing color space info. Bug: 758057, 8510131, 809835, 863103, 884170, 795132 Change-Id: I11056ddc4f501ee338dc3283397703747a395571 Reviewed-on: https://chromium-review.googlesource.com/c/1372894 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616936}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .