commit | f1ee44d0df41ac201a752fdd3bf594b4b7ad9d57 | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Fri Dec 14 16:21:31 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 14 16:21:31 2018 |
tree | 1e879fe18263afae8599fce75c47392824d1e63d | |
parent | 71e551ac476ec9b247be8f19c6eb696632d90cf4 [diff] |
Revert "Embed all localized strings into GCPW dll directly to allow localization." This reverts commit 61e28c177145da085bdf576f2db782c5402213da. Reason for revert: Broke compile on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Win%20Builder/102191 ../../chrome/credential_provider/gaiacp/gcp_utils.cc(46,10): fatal error: 'chrome/credential_provider/gaiacp/gaia_resources.h' file not found #include "chrome/credential_provider/gaiacp/gaia_resources.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Looks like this is probably missing a gn dep to make sure the header is generated by the time it is included. Original change's description: > Embed all localized strings into GCPW dll directly to allow localization. > > - Code that generates the strings to be embedded into an > executable in chrome/installer/util was adapted so that it could be > used generically anyone. > - Used this common code to embed the strings into gaia1_0.dll and use > them directly in code. > > Bug: 908451 > Change-Id: I6f40dc08aee8553358c775aeda82b8d0ed7a5db2 > Reviewed-on: https://chromium-review.googlesource.com/c/1352576 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Tien Mai <tienmai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616695} TBR=rogerta@chromium.org,thakis@chromium.org,grt@chromium.org,tienmai@chromium.org Change-Id: I8a26588d125713cd2a1c6c925a5adbbf91e47219 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908451 Reviewed-on: https://chromium-review.googlesource.com/c/1378405 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#616702}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .