Google Git
Sign in
chromium / chromium / src.git / f800edbd1b50ecc13a0d3391f5f45ba9c84625be
commitf800edbd1b50ecc13a0d3391f5f45ba9c84625be[log] [tgz]
authorDaniel Murphy <dmurph@chromium.org>Mon Oct 19 19:18:22 2020
committerCommit Bot <commit-bot@chromium.org>Mon Oct 19 19:18:22 2020
tree8871292af7fd3e15e1dd5f53db317058f7091445
parentf4d00c78955f00f21b5a30766cc955ab044c0255 [diff]
Hardcode default apps to not have protected storage.

This fixes an issue I introduced in m85 here:
https://chromium-review.googlesource.com/c/chromium/src/+/2181827
during our migration of all "bookmark apps" off of the extensions system
and onto the WebAppProvider system.

Making YouTube no longer a 'bookmark app' (and back to a hosted app)
had the side effect of making its storage protected, because apparently
all hosted apps have their storage protected.

This change marks all potential default hosted apps as no longer
receiving protected storage.

The long term fix for this issue is to have the WebAppProvider system
support default apps, and migrate these old hosted apps (which is a
double-deprecated system) onto the WebApp platform:
https://bugs.chromium.org/p/chromium/issues/detail?id=1140122

R=cmp@chromium.org

Bug: 1139902
Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818570}
1 file changed
tree: 8871292af7fd3e15e1dd5f53db317058f7091445
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.