Google Git
Sign in
chromium / chromium / src.git / f9cbe23f623682e17c7a90c8a88d2ece6b61ca00
commitf9cbe23f623682e17c7a90c8a88d2ece6b61ca00[log] [tgz]
authorjongdeok.kim <jongdeok.kim@navercorp.com>Fri Jul 31 23:03:01 2020
committerCommit Bot <commit-bot@chromium.org>Fri Jul 31 23:03:01 2020
tree863d3da45c5668aac4b72517bbf9d6d6118f7f93
parentf9657f8c7b31b445140757a9dcb82b129cda5036 [diff]
Make SquaredDistanceBetweenRects() distinguish intersection.

When DIPToScreenRect() is asked to find the nearest display to a given rect, it uses the minimum SquaredDistanceBetweenRects() to choose.  Since adjacent and overlapping rectangles had the same reported distance (0), a rect on one monitor but touching another could be reported as nearest to the adjacent one, which is clearly incorrect.

(cherry picked from commit c294ba3378d6f623f36f16b07776082782f27a9e)

Bug: 1097049
TBR: jongdeok.kim
Change-Id: I626c3ba07d5e084b1a9062b780b2f5d333e26ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315663
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#793268}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333295
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/branch-heads/4183@{#1098}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
4 files changed
tree: 863d3da45c5668aac4b72517bbf9d6d6118f7f93
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.