commit | 01f90f504217e4c37b1b75aa2c8813ad2f99be8d | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Tue Jan 15 11:36:19 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 15 11:36:19 2019 |
tree | d2124ca9da0a83aa19523c4491c94045cf246724 | |
parent | 9129b970f8d600e00d05d1a6a85658fbe21c8eeb [diff] |
Make named constructors' |prototype|s have the right property descriptor As per https://heycam.github.io/webidl/#named-constructors, a named constructors "prototype" property should NOT be writable, configurable or enumerable, yet we were creating a property with the opposite characteristics. Call v8::Object::DefineOwnProperty() rather than v8::Object::Set() so we can pass the property descriptor values we want. More tests for named constructors are coming in https://github.com/web-platform-tests/wpt/pull/14841 While here, do some minor cleanups suggested in the review: * Rename |interfacePrototype| to |interface_prototype| to follow Chromium's coding style * Replace an if check for |result| with a CHECK(), as we are already calling ToChecked() when setting it. Bug: 921633 Change-Id: Ie1f31c7eb456f45e113cff3048f43aea7e05e8ba Reviewed-on: https://chromium-review.googlesource.com/c/1409552 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#622814}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .