commit 02a45d5f271b900ed0a88ed51130f7156c7d3ee8
author Tim Volodine <timvolodine@chromium.org> Fri Nov 30 20:56:55 2018
committer Commit Bot <commit-bot@chromium.org> Fri Nov 30 20:56:55 2018
tree 654d1c813f395becdfab45ebf80ef98f38b898f1
parent 6a796b426b1ff987c8e4fd63d838731bcfd50d54

[AW NS] Fix failing ClientOnReceivedError2Test tests: header is not necessarily empty.

Update the relevant failing ClientOnReceivedError2Test tests
(listed below) to not check for empty headers. Request headers
in onReceivedError callback may or may not be empty, this is
an implementation detail. In the network service code path
they may e.g. contain user agent, see https://crbug.com/893573.

Also add a comment in tests explaining this.

Fixed tests:
-ClientOnReceivedError2Test.testIframeSubresource
-ClientOnReceivedError2Test.testImageSubresource
-ClientOnReceivedError2Test.testMainFrame
-ClientOnReceivedError2Test.testUserGesture
-ClientOnReceivedError2Test.testUserGestureForIframeSubresource

BUG=893573,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ic6322c7d9720b62709c2b506639108ed2a36a188
Reviewed-on: https://chromium-review.googlesource.com/c/1356801
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612777}