Google Git
Sign in
chromium / chromium / src / 044be6f1fb29701ea0e8f5157f6eed41c0950d98
commit044be6f1fb29701ea0e8f5157f6eed41c0950d98[log] [tgz]
authormlcui <mlcui@google.com>Wed Jan 18 08:33:31 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 18 08:33:31 2023
treeed9d14cfb6cea15a465ef97bc73b4109099feefa
parentf87dee47e5b54dedeefcf5b6c379e5a3bb7e1c74 [diff]
os_languages_page: Fix race condition in test for TS migration

The TypeScript migration has revealed that os_edit_dictionary_page_test
has a race condition, with the root cause being that
`OsSettingsEditDictionaryPageElement.words_` was shared between
instances of the class.

Per b/265556004, we should move these to be set in the constructor if
possible.

Bug: b:265556004, b:263829183
Change-Id: Id7a0c21f3e8b67a8f5cd2e99b855d9c0a90b655e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4170025
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1093764}
1 file changed
tree: ed9d14cfb6cea15a465ef97bc73b4109099feefa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.