)]}'
{
  "commit": "04f5eaaa234b142614e315f3ccd94f4e55015f10",
  "tree": "4f5681437faad122280ec59d98590c974caa6dfc",
  "parents": [
    "e2d021cbb3a6630d498d33527f264566df019cad"
  ],
  "author": {
    "name": "drott",
    "email": "drott@chromium.org",
    "time": "Tue Nov 29 10:20:22 2016"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Tue Nov 29 10:22:41 2016"
  },
  "message": "Improve fallback for Burmese with leading punctuation + spacing mark\n\nReland after revert in 1b8f4236e2dbf4e07bf0171300003168633b8660,\nprevious CL https://codereview.chromium.org/2530153002/\nPreviously failing Win10 test needs a rebaseline.\n\nIssue 618178 describes an example where a Burmese text run starts with a\nleading punctuation character followed by a combining spacing mark. This\ngrapheme cannot be shaped with the default font, since Times for example\ncannot display the combination of a left quote with a Burmese combining\nmark. Our fallback code attempts to find a fallback font based on the\nfirst character at the beginning of an extracted unshaped sub-run, which\ndoes not lead to finding a font suitable for Myanmar text in this case.\nSo in a way it runs into a fallback trap, where no fallback hint helps\nto find the right fallback font and the whole run ends up as notdef\nglyphs.\n\nThis CL attempts to resolve this by looking for a better fallback hint\ncharacter, which is not script common or inherited, if such is\navailable. This improves the situation for the Burmese text from the\nissue report.\n\nIn addition, as a better fix we should give higher importance to the\nlocale information in font fallback, filed as issue 668706.\n\nBUG\u003d618178\nTBR\u003deae,kojii,behdad\n\nReview-Url: https://codereview.chromium.org/2539733002\nCr-Commit-Position: refs/heads/master@{#434944}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ef25e0bcd825040904b23a18151f66fecedb22e0",
      "old_mode": 33188,
      "old_path": "third_party/WebKit/LayoutTests/NeverFixTests",
      "new_id": "39cb1a1ae5516a373daaf39f7fe36d354c136f3b",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/NeverFixTests"
    },
    {
      "type": "modify",
      "old_id": "236a4e7bdfc23c509e06ce759b49669b56c1a9f1",
      "old_mode": 33188,
      "old_path": "third_party/WebKit/LayoutTests/TestExpectations",
      "new_id": "7a9e3bdad842c1ca5e47566d46eb8bff0edd78d9",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/TestExpectations"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b286bce29ccad824ced42d26345f4f2edadbe6a2",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/inspector-protocol/layout-fonts/fallback-myanmar.html"
    },
    {
      "type": "modify",
      "old_id": "cc36025e089b76e92b05a4272cee78c1959b9426",
      "old_mode": 33188,
      "old_path": "third_party/WebKit/LayoutTests/inspector-protocol/layout-fonts/resources/layout-font-test.js",
      "new_id": "f3efc867dbe447c503b6f2714929208aa9567414",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/inspector-protocol/layout-fonts/resources/layout-font-test.js"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "24429699237ef613e9d99d1a4c9a48ee26c804c6",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/platform/mac/inspector-protocol/layout-fonts/fallback-myanmar-expected.txt"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "e2d32774c76242ea469966d8cb831e14ed75f7f9",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/platform/win/inspector-protocol/layout-fonts/fallback-myanmar-expected.txt"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b1c7fceb95b2b65ac4692fc216717d798a223209",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/LayoutTests/platform/win7/inspector-protocol/layout-fonts/fallback-myanmar-expected.txt"
    },
    {
      "type": "modify",
      "old_id": "9b3283cb4f48c5ddb5a9c25e4253bc0b2ea130ed",
      "old_mode": 33188,
      "old_path": "third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp",
      "new_id": "0f9fa07fca42181f828e4f65b15d784faeb697e8",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp"
    },
    {
      "type": "modify",
      "old_id": "9a3f0dde923c427d78db03b4b80488eed6e9b515",
      "old_mode": 33188,
      "old_path": "third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h",
      "new_id": "4b8f30ccb7f92630cf40fec895b49eb9d929f326",
      "new_mode": 33188,
      "new_path": "third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h"
    }
  ]
}
