commit | 05952b87c1931da7908b9a00911534046d9c9124 | [log] [tgz] |
---|---|---|
author | Noel Gordon <noel@chromium.org> | Fri Feb 12 06:27:20 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 12 06:27:20 2021 |
tree | 08eb0c5bd7dcd0a078bcafe5ae583dd9fbf77e5c | |
parent | 08bca0da89edb676ac917369f5e73e5e0ffba169 [diff] |
[filesapp] Make Cancel the default button of the delete confirm dialog Delete is the default button of the delete confirm dialog. Change that to the Cancel button to resolve issue 1104191. Add / update tests: test.toolbarDeleteButtonOpensDeleteConfirmDialog (new test) • use to toolbar Delete button to open the delete confirm dialog • verify the dialog Cancel button is focused by default testcase.toolbarDeleteButtonKeepFocus (update test) • use to toolbar Delete button to open the delete confirm dialog • click the dialog Cancel button to close the dialog • verify the focus returns to toolbar Delete button: replace the existing verification code with a robust CSS :focus selector • update comments Test: browser_tests --gtest_filter="*FilesAppBrowserTests*" Bug: 1104191 Change-Id: I2465f75b85edd64d9df669d4410b3f82e3edeebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2690621 Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#853416}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.