Google Git
Sign in
chromium / chromium / src / 05b5a683476df6087f560da5cae365b5408ace0c
commit05b5a683476df6087f560da5cae365b5408ace0c[log] [tgz]
authorMustafa Emre Acer <meacer@chromium.org>Tue Jan 05 22:41:55 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 05 22:41:55 2021
tree0895561d8bbfe5dc80dc44893f5cbbe2c4d3276f
parent0b09ffb44aedbaef3d085f7ec76cc58c681fd287 [diff]
Default typed omnibox navigations to HTTPS: Don't wait forever for HTTPS

When upgrading a typed omnibox navigation to HTTPS, we observe the HTTPS
load and fallback to HTTP if it fails. For slow HTTPS sites, this will
introduce a very user visible delay.

Instead of indefinitely waiting for the HTTPS navigation to succeed or
finish, this CL implements a timeout so that we can cancel the HTTPS
navigation (i.e. the "upgrade") and fall back to HTTP.

Bug: 1141691
Change-Id: I8ec6d4bdd42abd2a9b8f90a802b9280cc0ded6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577633
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840353}
3 files changed
tree: 0895561d8bbfe5dc80dc44893f5cbbe2c4d3276f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.