Google Git
Sign in
chromium / chromium / src / 061a338c852c9666e6d18b2c2d765e77da8c0df9
commit061a338c852c9666e6d18b2c2d765e77da8c0df9[log] [tgz]
authorVaclav Brozek <vabr@chromium.org>Wed Jul 25 11:40:02 2018
committerCommit Bot <commit-bot@chromium.org>Wed Jul 25 11:40:02 2018
tree66f12046040b26d91a3a6302f687a45b69f772fb
parent2a084e47a1a0362a14359639598777094ba34547 [diff]
Add reporting UsernameDetectionMethod from new parser

The old FormData -> PasswordForm parser reported to the
PasswordManager.UsernameDetectionMethod histogram, which method was used
to detect the username in the form.

This CL teaches the new parser to do the same.

The supporting enum is copied from the old one and modernised. There is
not point in attempting to share that code given that the old parser is
going away soon.

Bug: 845426
Change-Id: I7737cb8dc598c11b42c0e7e0f929afed5e830d7c
Reviewed-on: https://chromium-review.googlesource.com/1149866
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577841}
4 files changed
tree: 66f12046040b26d91a3a6302f687a45b69f772fb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .