Google Git
Sign in
chromium / chromium / src / 06bd89a47817d4c4fa3c3aff2fe31df53bd98515
commit06bd89a47817d4c4fa3c3aff2fe31df53bd98515[log] [tgz]
authorTommy Steimel <steimel@chromium.org>Mon Feb 04 17:50:10 2019
committerTommy Steimel <steimel@chromium.org>Mon Feb 04 17:50:10 2019
treeb2d0af1372b703f48c39abd6397b429d90a1ea6e
parent0040c02c38c5bc25c227a2dbf3a28b7c5bcd2399 [diff]
[Media Controls] Allowing tabbing into controls after touch

This CL modifies MediaControlsImpl's OnFocusIn handler to only prevent
showing the controls while the tap timer is running, instead of anytime
we're using touch controls. This fixes an issue where users were unable
to tab into the controls after touching on the video.

Bug: 919784
Change-Id: I7babc2665ecf7ce0bfe32905982caaa5c5843395
Reviewed-on: https://chromium-review.googlesource.com/c/1447029
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#627743}(cherry picked from commit 4dd5227997a010d8197c308a5625359f28d2a828)
Reviewed-on: https://chromium-review.googlesource.com/c/1452460
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#169}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
2 files changed
tree: b2d0af1372b703f48c39abd6397b429d90a1ea6e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .