Google Git
Sign in
chromium / chromium / src / 076e037047ae0852f57a41529174bb6853adf47b
commit076e037047ae0852f57a41529174bb6853adf47b[log] [tgz]
authorMaksim Sisov <msisov@igalia.com>Wed Sep 15 05:30:21 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 15 05:30:21 2021
treeeadd4a514210e74e3c068844db896f55bd4ad38d
parentee8a9d0ab3c24036111cae8aabdeb872ee85bb8b [diff]
ozone/wayland: fixed order of presentation feedback and swap result.

GLSurfaceWayland permits calling SwapBuffers if the window it
backs has not been configured yet (otherwise, a buffer is attached
before the surface is configured, which is illegal in Wayland).

However, they way it did so resulted in incorrect order of swap
results and presentation callbacks - swap result must be sent
before a presentation callback. Thus, use ScopedSwapBuffers, which
runs the callback with some delay (it's the same technique used
below in NativeViewGLSurfaceEGL, but we don't have a way to
force it to fail. Thus, GLSurfaceWayland does that instead).

Bug: 578890
Change-Id: Ic8e7f27c0effa55341a7b45d0b0d7288715644a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150277
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/main@{#921536}
2 files changed
tree: eadd4a514210e74e3c068844db896f55bd4ad38d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.