)]}' { "commit": "07c444c4d2813a493a21ba3f7ec01b201b8c1876", "tree": "6cc6ba4212101d07fddeb66be37ca26837bdafed", "parents": [ "3e6249c779675f1b009d0ab8f79b638fea70155f" ], "author": { "name": "Michael Thiessen", "email": "mthiesse@chromium.org", "time": "Fri Apr 26 03:53:11 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 26 03:53:11 2019" }, "message": "Expose Spatial Navigation state to the browser.\n\nThis change exposes the necessary bits of spat nav state for\nimplementing basic controlling logic in the browser, or indicating what\nfunctionality is available.\n\nThis change also ensures the Spatial Navigation controller is\ninitialized before receiving a directional key so that the browser has\nthe correct initial state, and sites that focus elements that intercept\ndirectional keys don\u0027t prevent spat nav from initializing or breaking\nout of that focused element with the exit key.\n\nBug: 938534, 951544\nChange-Id: I27fd9832d72f8d2d820a9b75c54f3861a4d34da2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562714\nCommit-Queue: Michael Thiessen \u003cmthiesse@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: David Bokan \u003cbokan@chromium.org\u003e\nReviewed-by: Yaron Friedman \u003cyfriedman@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#654342}\n", "tree_diff": [ { "type": "modify", "old_id": "1702355cc4f851af8007cbd69fcc7d32888eabb1", "old_mode": 33188, "old_path": "chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java", "new_id": "6b48bafd4138d1f0d6f2555cfc00962fc83db089", "new_mode": 33188, "new_path": "chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java" }, { "type": "modify", "old_id": "63a2cce7c3988e1789355b0b386736aef029617e", "old_mode": 33188, "old_path": "chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java", "new_id": "81ac3c5c62caae12194c3554178921a75262f1b2", "new_mode": 33188, "new_path": "chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java" }, { "type": "modify", "old_id": "00ad09da74f550660ba3b7ca4597894b36125aa2", "old_mode": 33188, "old_path": "chrome/app/chrome_content_browser_overlay_manifest.cc", "new_id": "ed1c9a10abccd7e4cd09de7fd74ef9d131aa92a7", "new_mode": 33188, "new_path": "chrome/app/chrome_content_browser_overlay_manifest.cc" }, { "type": "modify", "old_id": "45b402960dfdced91b878dea234e4b46f4f50f8b", "old_mode": 33188, "old_path": "chrome/browser/BUILD.gn", "new_id": "5e268e4c44025b93244715d50bd423bc083ffb41", "new_mode": 33188, "new_path": "chrome/browser/BUILD.gn" }, { "type": "modify", "old_id": "e4911b97c99b332e79c8b61b0d5a4df1e56f217b", "old_mode": 33188, "old_path": "chrome/browser/chrome_content_browser_client.cc", "new_id": "7dbf939754e5a399398e4940db25cf332d3f1138", "new_mode": 33188, "new_path": "chrome/browser/chrome_content_browser_client.cc" }, { "type": "modify", "old_id": "d76ea97abcad4a22e22dc7cdcb655650df168b4e", "old_mode": 33188, "old_path": "third_party/blink/public/mojom/BUILD.gn", "new_id": "181640e24921f698e7c21f60af5c6d0dac80c375", "new_mode": 33188, "new_path": "third_party/blink/public/mojom/BUILD.gn" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "5ba18590468432b5444ca059796146cd4f9e5d6f", "new_mode": 33188, "new_path": "third_party/blink/public/mojom/page/spatial_navigation.mojom" }, { "type": "modify", "old_id": "9a0daee863be5c3fa01d53b882eebfe7a0f1e5cc", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/dom/document.cc", "new_id": "1ed7c65e4c9efb4d79776409f8ceada16ffa2b0c", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/dom/document.cc" }, { "type": "modify", "old_id": "8bf78be7e3a787fcd4111fc7bc2099034f6b80d0", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/frame/settings.json5", "new_id": "9088fd737d9a19b469576e765a11b71644ec813a", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/frame/settings.json5" }, { "type": "modify", "old_id": "4e64deeb5cea7d1ebd59a784803a91bff9da27c9", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/frame/settings_delegate.h", "new_id": "428173cd8c56b3d5c8b55b781ca52a92db94ce8b", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/frame/settings_delegate.h" }, { "type": "modify", "old_id": "053b9c9156473dc9f9787ed8e662646231e86f3c", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/input/fallback_cursor_event_manager.cc", "new_id": "04ae7f873c505c330a75850fc153b44efc03ce51", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/input/fallback_cursor_event_manager.cc" }, { "type": "modify", "old_id": "4776bb139a6a1e05e84200c89681be3d08b4cf50", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/input/fallback_cursor_event_manager.h", "new_id": "f1a0178cc4c363f84e506672f2511be0e4817686", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/input/fallback_cursor_event_manager.h" }, { "type": "modify", "old_id": "5480f0e29789df1e62f99a3895f76bd85cd561f8", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/page/page.cc", "new_id": "15d0f1b913528f239ac04cf35a5ea1ef3f4fb26c", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/page/page.cc" }, { "type": "modify", "old_id": "3cb806027557ba8e6638c20bd866e289408951b4", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/page/spatial_navigation.cc", "new_id": "378184826788634c8c46bbc23e8d34e728f9a310", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/page/spatial_navigation.cc" }, { "type": "modify", "old_id": "1e81ef71d4c9a4bd7cf2362f55baf052e9b219da", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/page/spatial_navigation_controller.cc", "new_id": "4fc29b1d294f4515707f0e1534773eaf224909b0", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/page/spatial_navigation_controller.cc" }, { "type": "modify", "old_id": "db5b9dd9f20d83df09df94612676498b2530bb29", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/page/spatial_navigation_controller.h", "new_id": "b1a794fccd98bd49ce91bb0d2869b681b57dab83", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/page/spatial_navigation_controller.h" }, { "type": "modify", "old_id": "3dcec20834acdda4b92c0362a06f2b2b982004cc", "old_mode": 33188, "old_path": "third_party/blink/web_tests/VirtualTestSuites", "new_id": "804d953188aa732716e2df3ed1319d2a59fad1e7", "new_mode": 33188, "new_path": "third_party/blink/web_tests/VirtualTestSuites" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b0c445b9fe1bebfa0cc9685e5810a8d0151ff852", "new_mode": 33188, "new_path": "third_party/blink/web_tests/fast/spatial-navigation/resources/mock-snav-service.js" }, { "type": "modify", "old_id": "21061b0f93cf4ca3bcdc7f74ba79c65e4c8607a0", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/resources/snav-testharness.js", "new_id": "ab4d3d117c2b1eebfa8320e3af790ec8e71510b0", "new_mode": 33188, "new_path": "third_party/blink/web_tests/fast/spatial-navigation/resources/snav-testharness.js" }, { "type": "delete", "old_id": "4de0a123271d3898d6276733e6f681432f96b9cc", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-enter-from-interest.html", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "3708aa3399029cbdd1789223645c66fb84bb670a", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-interested-element-indicated.html", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "f00d702dd1df0f20e776ba9418a416e8320c16d7", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-reset-interest.html", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "64270bb488af25faaa122dbd4dd7f8a31683a77e", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/README.txt" }, { "type": "rename", "old_id": "f8b0a2f7134ef9230093167646437674521fda80", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-basic-movement.html", "new_id": "889818f8cf6cb38b32af760e67a54e071ff28639", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-basic-movement.html", "score": 75 }, { "type": "rename", "old_id": "d3a7d9d70c2c1aa26f9b31555ca9504aa99923c1", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-checkbox-radio.html", "new_id": "d274d412d27ece3a9273ae721e7b99c1fb43eb41", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-checkbox-radio.html", "score": 67 }, { "type": "rename", "old_id": "a43a0a99ae1936b2b91e6e19598da49af17869e4", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-disconnected-document.html", "new_id": "274a2799ed6f11f781298393157481f7d46505ff", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-disconnected-document.html", "score": 81 }, { "type": "rename", "old_id": "7ae40b5fca3b1ddcd4f4392f6a5e34ed268bc995", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-disconnected-editable.html", "new_id": "efb45d542b7f7b5cd306d399e143167aab260a11", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-disconnected-editable.html", "score": 73 }, { "type": "rename", "old_id": "df52d91c1df0c77cc61c7d5aa5d19b7c9cb4050d", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-display-none-editable.html", "new_id": "3c1b26379baee5ae7d85130de0b18f3ce3083b91", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-display-none-editable.html", "score": 79 }, { "type": "rename", "old_id": "82edaf52b849ad9a6dd1810345fe405be3e678f2", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-dont-send-keyboard-events.html", "new_id": "12161914c762dd29131402801d7feb9ac6a54991", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-dont-send-keyboard-events.html", "score": 71 }, { "type": "rename", "old_id": "7863dc119762d8ab376a9a5e18659c81f978eb13", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-element-removed.html", "new_id": "44778ac013d46f65bffa149f1368fcc11bdd4f34", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-element-removed.html", "score": 66 }, { "type": "rename", "old_id": "845e3377f2938cf4885efb04896e4256f631ff8c", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-enter-exit-focus.html", "new_id": "9637a7406e0d2d469e493733c953962de37b60ea", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-enter-exit-focus.html", "score": 69 }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "6c63d61a6a1b3538f186b412d35a086980ca5f8a", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-enter-from-interest.html" }, { "type": "rename", "old_id": "7f1e195bc437fe0f69d9ae5bf3f64dbe436afe71", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-escape-uninterested-focus.html", "new_id": "a853a1e88d710351a2c217cc9b89c1de94e304f3", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-escape-uninterested-focus.html", "score": 70 }, { "type": "rename", "old_id": "dca44e9b8d8dd6ea8c508e5b163083991cb6e834", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-focused-editable-blocks-movement.html", "new_id": "435a4f50fd3d58fcea59733fbf777c866ffcfa5e", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-focused-editable-blocks-movement.html", "score": 83 }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3fb47bba02f48f35b3aaeafb7e02d663c1b76666", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-form-state-on-click.html" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "488f889f0daa80038ac6e1c0572a0c8fd7591593", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-form-state.html" }, { "type": "rename", "old_id": "83dbcf4fcb6a3cab45d7e9ab5ee216fa13d052bd", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-interested-element-indicated-expected.html", "new_id": "83dbcf4fcb6a3cab45d7e9ab5ee216fa13d052bd", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-interested-element-indicated-expected.html", "score": 100 }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "efe2de3c30f733e8e18a1143c101544f2f7d4987", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-interested-element-indicated.html" }, { "type": "rename", "old_id": "42238c8c664f1bfbd9031d3bcc160bb0af906ddb", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-mouse-enter-leave.html", "new_id": "1567a7ff5920f7722bca6fa2f5f0af50d4edb99b", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-mouse-enter-leave.html", "score": 88 }, { "type": "rename", "old_id": "a13b93e6d2d25d952768ff9a2ab01714372215b3", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-navigate-from-focus.html", "new_id": "0fed16a566d6db6bd05f03437d008c28c3ec8364", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-navigate-from-focus.html", "score": 74 }, { "type": "rename", "old_id": "f24c4b2e4979e1c353e53ca835cf6874373c79c7", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-navigate-to-click-handler.html", "new_id": "ae73bc2c63d6c6027089eec5ccbc744e24d4b662", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-navigate-to-click-handler.html", "score": 69 }, { "type": "rename", "old_id": "9007b09e436fe04dfac1ad8975fec8c023b9b4ad", "old_mode": 33188, "old_path": "third_party/blink/web_tests/fast/spatial-navigation/snav-focusless-prevent-key-event.html", "new_id": "22a43682d72663410e104a177e8f52b10690c294", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/focusless-spat-nav/fast/spatial-navigation/focusless/snav-focusless-prevent-key-event.html", "score": 83 } ] }