Google Git
Sign in
chromium / chromium / src / 09a1f53e39973f72e0e71c5080c78f70141934d6
commit09a1f53e39973f72e0e71c5080c78f70141934d6[log] [tgz]
authorJihwan Marc Kim <bluewhale.marc@gmail.com>Fri May 24 12:40:48 2019
committerCommit Bot <commit-bot@chromium.org>Fri May 24 12:40:48 2019
tree4d2ec6874790e56199445beb5c2079c2d65aebb9
parente8b0b899d62acf4721c1c1e70aa855ea4e445e12 [diff]
Keep scroll by keyboard after child focused node is removed

So far, scroll stops if focused child node is removed
while scrolling parent node.
This is because the event handler passes the |MousePressNode|.
If focused child node(|MousePressNode|) is removed,
it will be null and scrollable area changed to document.

|LogicalScroll| finds scrollable area from |MousePressNode|.
If we save this scrollable area node,
we can get one more chance to find proper node to scroll.


Bug: 493078
Change-Id: I6e81ca0a0d15e0def66c8457840ca9e1343e8dba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611620
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663040}
5 files changed
tree: 4d2ec6874790e56199445beb5c2079c2d65aebb9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .