commit 09c39a97125ed208cacc75bf830b02324780842d
author Daniel Bratell <bratell@opera.com> Tue Mar 26 09:37:34 2019
committer Commit Bot <commit-bot@chromium.org> Tue Mar 26 09:37:34 2019
tree 2d344546251d8ac41d7b187ca4f3a74ec6579fe2
parent 567b20ca007eb05020e675a5d97ccdd99bec6e40

Make the video_capture_types dep on media/base/ipc explicit

Core using video_capture_types (like components/mirroring) today
get includes not supported by dependencies (see below for an example).

This patch makes the dependency on media/base/ipc public so that
type users get the correct dependencies. This was found with
a new gn than can also check generated files.

In total, this change fixes 16 dependency errors similar to:

ERROR at //out/Default/gen/components/mirroring/mojom/resource_provider.mojom-test-utils.cc:32:11: Can't include this header from here.
          ^----------------------------------
The target:
  //components/mirroring/mojom:service
is including a file from the target:
  //media/base/ipc:ipc

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //components/mirroring/mojom:service -->
  //media/capture/mojom:video_capture --[private]-->
  //media/base/ipc:ipc


Bug: 938893
Change-Id: I82864323534f32a9e5ed3e90e7132215267626c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515534
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#644233}