[line-clamp] Make `ComputedStyle::LineClamp` ignore invalid `-webkit-line-clamp`

When adding the `line-clamp` property in crrev.com/c/5317993, the
existing `ComputedStyle::LineClamp` method was changed to return the
value of this property, if not `none`, or otherwise the value of
`-webkit-line-clamp`. And similarly for `ComputedStyle::HasLineClamp`.

However, while the `line-clamp` property applies to every block
container, the `-webkit-line-clamp` property only takes effect for
boxes with the `display: -webkit-box` and
`-webkit-box-orient: vertical` styles. That meant that in practice,
uses of `ComputedStyle::LineClamp` had to be guarded behind conditions
that checked this.

This patch changes those two methods to only use the value of
`-webkit-line-clamp` when those conditions hold, returning 0
(corresponding to `none`) otherwise. The raw values of the properties
can be obtained with `StandardLineClamp` (for the unprefixed property)
and `WebkitLineClamp` if needed.

Bug: 40336192
Change-Id: Iabc08cd4bcb114dbfeb566f15966c2f7565ee6d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457331
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Andreu Botella <abotella@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1287964}
4 files changed
tree: aeed6b68e6b3b361e5f430661295d46d8883a75b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  67. BUILD.gn
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.