)]}' { "commit": "0a6f46d38b7056c2380ea2e4b52dfced89f57124", "tree": "3f9663af6f579ad9163919959af1db3f5bcb8586", "parents": [ "3cc5b1224f7b914738e45d2a9062021f959946f4" ], "author": { "name": "Devlin Cronin", "email": "rdevlin.cronin@chromium.org", "time": "Tue Jun 25 18:37:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 25 18:37:14 2019" }, "message": "[Extensions] Enable action.setIcon and add end-to-end tests\n\nEnable the action.setIcon function (define the extension function,\nadd histogram values, and add custom bindings), and add a parameterized\nend-to-end test for setting the icon from both a local path and\ncanvas image data.\n\nBug: 893373\nChange-Id: I249d6e980469fe3af2c541db92bba09b2d87ce03\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658421\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nReviewed-by: Karan Bhatia \u003ckarandeepb@chromium.org\u003e\nCommit-Queue: Devlin \u003crdevlin.cronin@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#672167}\n", "tree_diff": [ { "type": "modify", "old_id": "1f2c8aa8225e578020467ad54d18c43c1f57acb1", "old_mode": 33188, "old_path": "chrome/browser/extensions/api/extension_action/extension_action_api.cc", "new_id": "2c0dc07d8bdc44add36987b04c884fc727eb2032", "new_mode": 33188, "new_path": "chrome/browser/extensions/api/extension_action/extension_action_api.cc" }, { "type": "modify", "old_id": "d75a9023c056388be6c12972708053f39111e4f7", "old_mode": 33188, "old_path": "chrome/browser/extensions/api/extension_action/extension_action_api.h", "new_id": "6c2385761454ae274130823a147a10856b572d06", "new_mode": 33188, "new_path": "chrome/browser/extensions/api/extension_action/extension_action_api.h" }, { "type": "modify", "old_id": "f46b80140cb612264e778c4c40894365d1a59a41", "old_mode": 33188, "old_path": "chrome/browser/extensions/api/extension_action/extension_action_apitest.cc", "new_id": "3792d8acdd5dc5ea4a33d78eed6ebe1377c384ec", "new_mode": 33188, "new_path": "chrome/browser/extensions/api/extension_action/extension_action_apitest.cc" }, { "type": "modify", "old_id": "d0f6fc7258b59742c6ea2d4df3eee2c4a825ba18", "old_mode": 33188, "old_path": "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc", "new_id": "0f44a18672559420422b4168614d85a9d3bb127c", "new_mode": 33188, "new_path": "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f526a23f27af2603a46493652944e0859badb06b", "new_mode": 33188, "new_path": "chrome/renderer/resources/extensions/action_custom_bindings.js" }, { "type": "modify", "old_id": "058e668c15643865dd155993bb2c5b08d37d64d4", "old_mode": 33188, "old_path": "chrome/renderer/resources/renderer_resources.grd", "new_id": "91746f85c3c13a006a694199ad3a021b8a7a2db0", "new_mode": 33188, "new_path": "chrome/renderer/resources/renderer_resources.grd" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a24e310d316b549c346ddeafe62f8180e67c4440", "new_mode": 33188, "new_path": "chrome/test/data/extensions/api_test/icon_rgb_0_0_255.png" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a4c3c7ed9d3f6408d8d42977c370dfb6af17b8bf", "new_mode": 33188, "new_path": "chrome/test/data/extensions/api_test/icon_rgb_255_0_0.png" }, { "type": "modify", "old_id": "551372d1d4ca98d0f3f6cc7063c6a64118cf3361", "old_mode": 33188, "old_path": "extensions/browser/extension_function_histogram_value.h", "new_id": "9ab2f23c62e5e787cb96a7a0bd70826bf3b9c045", "new_mode": 33188, "new_path": "extensions/browser/extension_function_histogram_value.h" }, { "type": "modify", "old_id": "0379efa0617540946ae25f33b4b2bd85a5cf0d70", "old_mode": 33188, "old_path": "tools/metrics/histograms/enums.xml", "new_id": "c3cb39e56e33d7d62964d15ed62954df21120dd0", "new_mode": 33188, "new_path": "tools/metrics/histograms/enums.xml" } ] }