commit | 0aa02f8093f51ad3cd22238e803839525fa23125 | [log] [tgz] |
---|---|---|
author | Kim Paulhamus <kpaulhamus@chromium.org> | Wed Feb 06 23:43:55 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 06 23:43:55 2019 |
tree | c04e7254096fad131a46aa7c400ae7b004d766b7 | |
parent | aea1502c11bf2291d5acc09b173118b3e3db1915 [diff] |
Postmortem states should not return errors until after user action. Three error states (timeout, keyNotRegistered, and keyAlreadyRegistered) were previously considered 'postmortem' states. This meant that dialogs corresponding to these states would be shown after a request was finished and after a DOMException was sent to the RP. This CL changes those states to instead block resolution of the request until the user acknowledges the dialog, and then close the request. Reworded 'postmortem' references to 'awaiting user acknowledgement' to better reflect this behavior. Bug: 897757 Change-Id: I04330f5a87ebbc960cd4c1e8d2c1b65fe97d9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1428879 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#629782}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .